Update Export_To_Excel.js #1987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where Date attributes become Strings during the export and therefore do not behave as Dates in the resultant Excel file and cannot have Date formatting applied to them.
Collaborator
|
https://github.com/mendix/web-widgets/pull/1941/files in this PR (unreleased), we are already implemented export types format |
Author
|
Awesome, great to see you're on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Fixes an issue where Date attributes become Strings during the export and therefore do not behave as Dates in the resultant Excel file and cannot have Date formatting applied to them.
What should be covered while testing?
Export from a DataGrid 2 widget that has at least one column where the attribute is a DateTime attribute. Test that dates in the exported file can be formatted (e.g. short date to long date, or change formatting to yyyy-MM-dd, MM/dd/yyyy, etc.) and that the change is applied.
Prior to this change, exported columns that are a datetime attribute should not change when formatting is applied because they are not true dates in the file.