Skip to content

[WC-3186]: Combobox(Database) onChange event firing unexpectedly #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahmanunver wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WC-3186]: Combobox(Database) onChange event firing unexpectedly #1992

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a78709
fix(combobox-web): remove redundant selection set
rahmanunver Nov 25, 2025
fb74915
fix(combobox-web): remove the onChange binding to selector
rahmanunver Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/combobox-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue with on change event firing unexpectedly when datasource type is set to database.

## [2.6.2] - 2025-10-29

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/combobox-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@mendix/combobox-web",
"widgetName": "Combobox",
"version": "2.6.2",
"version": "2.6.3",
"description": "Configurable Combo box widget with suggestions and autocomplete.",
"copyright": "© Mendix Technology BV 2025. All rights reserved.",
"license": "Apache-2.0",
Expand Down
9 changes: 0 additions & 9 deletions ...ges/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseSingleSelectionSelector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,6 @@ export class DatabaseSingleSelectionSelector<T extends string | Big, R extends E
this.customContentType = customContentType;
this.lazyLoading = lazyLoading;
this.loadingType = loadingType;

if (this.selection.selection === undefined) {
const objectId = this.options.getAll().find(option => {
return targetAttribute && _valuesIsEqual(targetAttribute?.value, this.values.get(option));
});
if (objectId) {
this.selection.setSelection(this.options._optionToValue(objectId));
}
}
}

setValue(objectId: string | null): void {
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/combobox-web/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Combobox" version="2.6.2" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Combobox" version="2.6.3" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Combobox.xml" />
</widgetFiles>
Expand Down
Loading