Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for allowing a header with no value #7

Closed

Conversation

henrikjonhed
Copy link

Possible fix for #6

@gfinlay
Copy link

gfinlay commented May 26, 2021

I agree with @ledbit regarding the proposed change to support empty header keyvalues.

  • 0x87, 6, 0xC1, 0xC1, 6, 0x87, 0x87, 0xC1, /* state 6: leading whitespace before header value */
  • 0x87, 6, 0xC4, 10, 6, 0x87, 0x87, 0xC1, /* state 6: leading whitespace before header value */
    Has this patch been tested? And is there a targeted date for completion / approval of the pull request and merging to the master (since this PR was created in 2017)?

By the way, I think that 10 is intentional - i.e. it is 0x0A rather than 0x10. This would make state 10 the next state. It could have alternatively been shown as 0x0A to make it clearer what the next state is when masked with 0x0F = since the lower 4-bits or nybble of the opcode is the next state, and state values are in the range 0-10.

Gordon Finlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants