Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default derivative impl to reverse mode #170

Draft
wants to merge 5 commits into
base: sritchie/proto
Choose a base branch
from

Conversation

sritchie
Copy link
Member

@sritchie sritchie commented Apr 24, 2024

This PR:

  • changes the default implementation of g/partial-derivative to use reverse mode automatic differentiation
  • adds new operators D-fwd and D-partial (kind of lame, what should these be?)

TODO:

  • add test coverage back for forward-mode, how do we cover the interesting test cases?
  • Add a switch between reverse and forward mode?
  • tests and docs for the new operator... is this a good way?

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 87.29%. Comparing base (0ee0d6d) to head (17f24ec).

Files Patch % Lines
src/emmy/calculus/derivative.cljc 37.50% 2 Missing and 3 partials ⚠️
src/emmy/differential.cljc 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           sritchie/proto     #170      +/-   ##
==================================================
- Coverage           87.53%   87.29%   -0.25%     
==================================================
  Files                  99       99              
  Lines               15777    15793      +16     
  Branches              850      853       +3     
==================================================
- Hits                13810    13786      -24     
- Misses               1117     1154      +37     
- Partials              850      853       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant