[pull] master from bitcoin:master #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The reference sender implementation and \`payjoin proposal\` test vectors are adjusted accordingly. According to the psbt Input Finalizer spec "All other data except the UTXO and unknown fields in the input key-value map should be cleared from the PSBT. The UTXO should be kept to allow Transaction Extractors to verify the final network serialized transaction." I ran into a problem where an LND acting as sender FinalizePsbt gRPC fails when sender utxo information is missing. I see no good reason to remove utxo information from the PSBT.
Disallowing mixed inputs was based on incorrect assumption that no wallet supports mixed inputs and thus mixed inputs imply PayJoin. However there are at least three wallets supporting mixed inputs. (Confirmed: Bitcoin Core, LND, Coinomi) Thus it makes sense to enable mixed inputs to avoid a payjoin-specific fingerptint. To avoid compatibility issues a grace period is suggested. Co-authored-by: Martin Habovstiak <[email protected]>
The original text is ambiguous to allowing transaction cut-through or not. Transaction cut-through enables savings by posting multiple transaction intents through a single 2-party payjoin and is used in practice in payjoins today. Let's explicitly allow it in the text. Co-authored-by: Martin Habovstiak <[email protected]>
It's an optional parameter in BIP 21 Bitcoin URIs, but it doesn't hurt to make it explicit. Co-authored-by: Martin Habovstiak <[email protected]>
These are required per BIP-2, and they avoid user confusion as seen in #1395 (comment)
Co-authored-by: Sebastian Falbesoner <[email protected]>
Co-authored-by: Sebastian Falbesoner <[email protected]>
Given that both BIPs are now final, calling them drafts, seem very stale.
BIP125: Update description of BIPs 68 and 112
* Update bip-0348.md * Update bip-0379.md
* typo bip-0087.mediawiki * typos bip-0088.mediawiki * typo bip-0098.mediawiki
* Update bip-0370.mediawiki * Update bip-0373.mediawiki
[BIP-373] Slight rewrite of evenness byte footnote for clarity
BIP39: replace incorrect word in Italian wordlist special considerations
https://github.com/btcsuite/btcutil/blob/master/gcs leads to a broken link. I'm assuming the correct replacement is at https://github.com/btcsuite/btcd/tree/master/btcutil/gcs since `btcutil` is a sub-package in `btcd`, as stated in https://github.com/btcsuite/btcutil/tree/master?tab=readme-ov-file
Co-authored-by: Jon Atack <[email protected]>
388: Add support for `musig` in descriptor templates
…enters spelling: globally change "implementor" to "implementer"
390: Add reference implementation
390: Fix created date
373: test vectors, reference implementation, update to Proposed
328: test vectors, reference implementation, update to Proposed
Corrects the 2 mismatches in the test vectors pointed out in #1764 (comment)
373: Correct test data mismatches
BIP3: Updated BIP Process
e.g. that NODE_NETWORK is not set See reference implementation bitcoin/bitcoin#10387 and this comment in that pull bitcoin/bitcoin#10387 (comment)
Not the same meaning, so not a purely editorial fixup, but I think "unwittingly" expresses the intended meaning.
BIP3: Address follow-ups from #1712
* Correct type error in sample JSON * first pass: moar data * more fiat and edits * more edits * add per-txn value * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * Update bip-0329.mediawiki Co-authored-by: Jon Atack <[email protected]> * edit * include @craigraw feedback * typo fix * add comment * further edits * broaden uses for address.heights --------- Co-authored-by: Jon Atack <[email protected]>
BIP 94: Move status to Final
Signed-off-by: costcould <[email protected]>
BIP75: fix BIP70 extensions url and clarify text
BIP329: PR 1750 follow-up edits
BIP159 updates
* BIP374: Add message to rand computation * BIP374: Update reference and test vectors * Add changelog * Format changelog according to BIP3 * Add creation date Co-authored-by: Jon Atack <[email protected]> * Grammar fix Co-authored-by: Jon Atack <[email protected]> * update changelog --------- Co-authored-by: Jon Atack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )