IT Payments #270
Merged
IT Payments #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucmkz
requested changes
Oct 11, 2023
e2e/payment/cancel.spec.ts
Outdated
| import type { PaymentCreateData } from '@src/clients/payment/create/types'; | ||
|
|
||
| describe('IT, cancel', () => { | ||
| test('should cancel Payment and match response object ', async () => { |
There was a problem hiding this comment.
Suggested change
| test('should cancel Payment and match response object ', async () => { | |
| test('should cancel Payment and match response object', async () => { |
e2e/payment/cancel.spec.ts
Outdated
| expect(cancelation).toHaveProperty('status', 'cancelled'); | ||
| }); | ||
|
|
||
| function createPayment(): PaymentCreateData { |
There was a problem hiding this comment.
This doesn't need to be a function, it just needs to be a common variable., Do the same for all occurrences
const createPaymentBody = {
body: {
additional_info: {
items: [
{
id: 'MLB2907679857',
title: 'Point Mini',
quantity: 1,
unit_price: 58.8
}
]
},
payer: {
email: '[email protected]',
},
transaction_amount: 110.00,
installments: 1,
payment_method_id: 'pix',
}
}
e2e/payment/cancel.spec.ts
Outdated
|
|
||
| describe('IT, cancel', () => { | ||
| test('should cancel Payment and match response object ', async () => { | ||
| const client = new MercadoPago({ accessToken: config.access_token, options: { timeout: 5000 } }); |
There was a problem hiding this comment.
To make the implementation simpler, let's remove the options part. Do the same for all occurrences
Suggested change
| const client = new MercadoPago({ accessToken: config.access_token, options: { timeout: 5000 } }); | |
| const client = new MercadoPago({ accessToken: config.access_token }); |
e2e/payment/capture.spec.ts
Outdated
|
|
||
| describe('IT, capture', () => { | ||
| test('should capture, return partial transaction_amount passed at the request and match response object', async () => { | ||
| const client = new MercadoPago({ accessToken: config.access_token, options: { timeout: 5000 } }); |
There was a problem hiding this comment.
To make the implementation simpler, let's remove the options part.
Suggested change
| const client = new MercadoPago({ accessToken: config.access_token, options: { timeout: 5000 } }); | |
| const client = new MercadoPago({ accessToken: config.access_token }); |
lucmkz
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description