feat: opentelemetry integration#346
Closed
PacoDu wants to merge 8 commits intomercurius-js:masterfrom
Closed
Conversation
…to opentelemetry-documentation
…- graphql' span and a 'mercurius.cached' attribute
Contributor
Author
|
Depends on #341 |
Collaborator
|
@Pablodu any updates on this one? |
Contributor
Author
|
This is a demonstration of a span usage inside the mercurius library, I don't have time right now to push it further unfortunately. |
Contributor
Author
|
superseded by #363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mercurius works with existing tools like
@autotelic/fastify-opentelemetryand@opentelemetry/instrumentation-graphql. But it's missing some mercurius specific spans and attributes that we can add with the opentelemetry API.As a reference, here is an example of a mercurius trace with a gateway and a service and without any additional opentelemetry integration:

And here is an example with a simple mercurius - graphql span added to the main fastifyGraphql function and a cached attribute (see PR changes):

We need to define what we want to expose in opentelemetry traces (spans and attributes). And maybe add a
telemetryoption to mercurius so user can enable/disable telemetry ?