feat: new website for mercurius #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tony133
force-pushed
the
feat/new-website-mercurius
branch
6 times, most recently
from
9619dfd
to
b67231f
Compare
Tony133
force-pushed
the
feat/new-website-mercurius
branch
from
b67231f
to
7bc56e7
Compare
|
The site to all pages, is complete, pending review , i attach some screenshots here as well here: 
|
|
This is awesome, I'll have a look and play with it in a bit! |
|
This is good, however we'd need support for multi-version similar to what Fastify has: https://github.com/fastify/website/blob/main/scripts/download-releases.sh |
jonnydgreen
reviewed
Sep 25, 2024
jonnydgreen
reviewed
Sep 25, 2024
|
For support for multi-version I succeeded in part, some files give me error ( see screenshot ) 
If you want I will do the push but it returns some errors maybe it is better to do it in a separate branch after the merge of this PR ? |
|
You can remove old versions, just keep the last two. |
|
I have added the following versions of Mercurius ( see screenshots )
I had to fix some of the titles so they were in line with the other titles in the sidebar and I removed the @mcollina as soon as you have time, let me know If it's okay 🙂 
|
|
Do you think it might also be useful to add a button to add a star to the mercurius project and a button to fork the mercurius project ? similar to the Fastify site ? ( see screenshot ) 
|
|
I added buttons to add a star to the mercurius project and a button to fork the mercurius project. I would say we should be there 💪😉 |
jonnydgreen
reviewed
Oct 12, 2024
There was a problem hiding this comment.
Just played with it locally and I found the following issue:
- The link in the footer appears to be incorrect?
After looking a little closer, and after running npm run build, I found the following broken links?
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/hooks.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/api.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/typescript.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/typescript.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-latest/hooks.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-latest/api.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/hooks.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-v14.1.x/api.md" for version v14.1.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v14.1.x/typescript.md" for version v14.1.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/typescript.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/typescript.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-v14.1.x/hooks.md" for version v14.1.x
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/hooks.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/api.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/typescript.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v14.0.x/typescript.md" for version v14.0.x
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-latest/hooks.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/hooks.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-latest/api.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-v14.1.x/api.md" for version v14.1.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v14.1.x/typescript.md" for version v14.1.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/typescript.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/typescript.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (./api/options.md) in source file "REDACTED/website/versioned_docs/version-v14.1.x/hooks.md" for version v14.1.x
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/api.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-latest/typescript.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-latest/typescript.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (/examples/graphiql-plugin/README.md) in source file "REDACTED/website/versioned_docs/version-v13.4.x/api.md" for version v13.4.x
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-latest/typescript.md" for version latest
[WARNING] Docs markdown link couldn't be resolved: (/docs/integrations/mercurius-integration-testing.md) in source file "REDACTED/website/versioned_docs/version-latest/typescript.md" for version latestOther than that, looks fantastic! :)
Link fixed see commit here: 8cd1562 |
jonnydgreen
approved these changes
Oct 14, 2024
|
I also made the one for Pino Logger, if you want to have a look at it: pinojs/website#1, very similar to the one by Mercurius, is awaiting review, hoping it will be approved |
|
I need to catch up on this, sorry :( |
No problem, as soon as you have time 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: mercurius-js/mercurius#1112