fix(MM2-1953): add vendor promotions rule attribute options middleware and update related validation logic #254
+218
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and update related validation logic
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kactok
reviewed
Dec 11, 2025
| ...buildFilters(attribute?.id, store), | ||
| promotion_type: promotionType, | ||
| application_method_type: applicationMethodType, | ||
| } as VendorPromotionRuleValueParams, |
Collaborator
There was a problem hiding this comment.
Shouldn't we set VendorPromotionRuleValueParams as the type of the query param in usePromotionRuleValues instead of type-casting it here?
…ions in promotions API hooks
kactok
reviewed
Dec 11, 2025
|
|
||
| const PROMOTIONS_QUERY_KEY = 'promotions' as const; | ||
|
|
||
| export type VendorPromotionRuleValueParams = HttpTypes.AdminGetPromotionsRuleValueParams & { |
Collaborator
There was a problem hiding this comment.
Should this be here? don't we have a separate file for types? vendor-panel/src/types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to backend PR -> mercurjs/mercur#532