Fix compare mode: side-by-side split view centers each frame in its own half#94
Conversation
Issue mergeos-bounties#14: Compare mode split view properly centers each frame within its clip region, showing each frame fully rather than cut in half at the midpoint. - overlay.js (source): adjust xOffset per half so frame A centers in left half, frame B in right half - beear-tryon.js (web + android bundles): same fix - Visual: dashed divider, bold A/B labels, frame names below
TUPM96
added
star: missing
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
13 similar comments
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
|
@chfr19820610-cell Gate 1 (badges) blocked on
Required community actionsFollow the orgStar both core repos
Done:
Policy: bounty Gate 1 requires all of:
Starring only Order: badges → security → tests → merge. Please complete the checklist above, attach evidence if needed, then comment when ready. |
2 participants
Summary
Fixes #14 — Side-by-side compare mode was clipping both frames at the face midpoint, showing only half of each frame. This fix centers each frame within its own clip region so both frames are fully visible.
Changes
packages/tryon-js/src/overlay.js: IndrawGlassesOverlay, computexOffsetper half — frame A shifts left bymidX - halfW/2, frame B shifts right byhalfW/2 - midX. Each frame now renders centered in its own half of the canvas.packages/web/assets/beear-tryon.jsandpackages/android/.../beear-tryon.js: Synced the same fix.Visual improvements
Testing
Closes #14