Skip to content

Species pack: Baby Rubber Plant#314

Open
yh-liao-07 wants to merge 1 commit into
mergeos-bounties:masterfrom
yh-liao-07:species-47-3sh2
Open

Species pack: Baby Rubber Plant#314
yh-liao-07 wants to merge 1 commit into
mergeos-bounties:masterfrom
yh-liao-07:species-47-3sh2

Conversation

@yh-liao-07

@yh-liao-07 yh-liao-07 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Resolves #47

Added species data for Baby Rubber Plant. Let me know if anything needs changing.

@TUPM96 TUPM96 added star: missing Must follow org AND star mergeos + mergeos-contracts evidence: missing PR needs screenshot, photo, GIF, or video evidence labels Jul 19, 2026
@TUPM96

TUPM96 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow missing (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

2 similar comments
@TUPM96

TUPM96 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow missing (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow missing (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96 TUPM96 added star: verified Follow mergeos-bounties org + star mergeos + mergeos-contracts and removed star: missing Must follow org AND star mergeos + mergeos-contracts labels Jul 20, 2026
@TUPM96

TUPM96 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

8 similar comments
@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@hualuoz hualuoz mentioned this pull request Jul 22, 2026
Open
@hualuoz

hualuoz commented Jul 22, 2026

Copy link
Copy Markdown

QA verification — request changes / close as superseded

Target

GitHub Actions

At the time of verification, both reported checks pass:

  • test (3.11) — pass
  • test (3.12) — pass

The PR itself is currently DIRTY / conflicting with master.

Local checks

Commands were run from the exact head commit above:

  • pytest -q — 41 passed
  • ruff check src tests — passed
  • ruff format --check src tests — failed on 7 pre-existing Python files. This PR changes only one JSON file, so the format failure is not introduced by this patch.
  • git diff 7a2ecd3^ 7a2ecd3 --check — passed
  • JSON parsing of data/species/peperomia_obtusifolia.json — passed

Manual acceptance testing

plantguide care show -s peperomia_obtusifolia exits successfully, but only because loader and care-card fallbacks supply missing values. The submitted JSON omits required issue fields:

  • Top-level: id, scientific_name, tags
  • Care object: summary, temperature_c, toxicity, common_issues, tips
  • It uses non-schema keys species and temperature instead.

The other acceptance paths fail:

  • data/samples/obs_peperomia_obtusifolia.json is missing.
  • The required query thick leaves,compact,indoor,easy ranks peperomia_watermelon first; peperomia_obtusifolia does not appear in the top three because the submitted record has no tags.
  • No two original or clearly licensed photos are attached.
  • The PR has the evidence: missing label and its description contains no test output or photo evidence.

Superseded status

Bounty #47 was completed by merged PR #322 on 2026-07-21. Current master already contains a complete peperomia_obtusifolia record with six tags and all required care fields. That explains the current merge conflict and makes this patch redundant even if its schema gaps were fixed.

Security / privacy

The one-file diff contains no credentials, private customer data, or obvious secret material.

Recommendation

Request changes / close as superseded. This PR is not ready for bounty acceptance: it fails the data, sample, identification, photo-evidence, and mergeability requirements, and the same bounty has already been delivered by merged PR #322.

QA payout account: github:hualuoz

@yh-liao-07

yh-liao-07 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ This PR is dirty (conflicts with master). Needs rebase on latest master.

Suggested fix: git rebase master and force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

evidence: missing PR needs screenshot, photo, GIF, or video evidence star: verified Follow mergeos-bounties org + star mergeos + mergeos-contracts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[25 MRG] Species pack: Baby Rubber Plant (peperomia_obtusifolia) — photo + care card

3 participants

@yh-liao-07 @TUPM96 @hualuoz