Skip to content

Species pack: Queen of the Night#316

Open
yh-liao-07 wants to merge 1 commit into
mergeos-bounties:masterfrom
yh-liao-07:species-44-6bog
Open

Species pack: Queen of the Night#316
yh-liao-07 wants to merge 1 commit into
mergeos-bounties:masterfrom
yh-liao-07:species-44-6bog

Conversation

@yh-liao-07

@yh-liao-07 yh-liao-07 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Resolves #44

Added species data for Queen of the Night. Let me know if anything needs changing.

@TUPM96 TUPM96 added star: missing Must follow org AND star mergeos + mergeos-contracts evidence: missing PR needs screenshot, photo, GIF, or video evidence labels Jul 19, 2026
@TUPM96

TUPM96 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow missing (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

2 similar comments
@TUPM96

TUPM96 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow missing (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow missing (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96 TUPM96 added star: verified Follow mergeos-bounties org + star mergeos + mergeos-contracts and removed star: missing Must follow org AND star mergeos + mergeos-contracts labels Jul 20, 2026
@TUPM96

TUPM96 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

8 similar comments
@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@TUPM96

TUPM96 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@yh-liao-07 Gate 1 (badges) blocked on mergeos-bounties/PlantGuide.

Badge Status
star / follow verified (core stars + org follow — not only this product repo)
evidence missing

Required community actions

Follow the org

  • (checking…)

Done:

  • Following mergeos-bounties

Star both core repos

  • (checking…)

Done:

  • Starred mergeos-bounties/mergeos
  • Starred mergeos-bounties/mergeos-contracts

Policy: bounty Gate 1 requires all of:

  1. Follow https://github.com/mergeos-bounties
  2. Star https://github.com/mergeos-bounties/mergeos
  3. Star https://github.com/mergeos-bounties/mergeos-contracts

Starring only mergeos-bounties/PlantGuide (or any single product) is not enough.

Order: badges → security → tests → merge.

Please complete the checklist above, attach evidence if needed, then comment when ready.

@hualuoz hualuoz mentioned this pull request Jul 22, 2026
Open
@hualuoz

hualuoz commented Jul 22, 2026

Copy link
Copy Markdown

Independent QA report — PR #316

Verdict: request changes / close as superseded. I verified the immutable head commit 46049dc384b320628803f6e0f8c4558a3b8dfe78. The submitted JSON parses and the existing tests pass, but the PR does not satisfy the linked bounty's functional acceptance criteria. PR #319 has since supplied the complete pack and was merged.

Scope and CI

  • Reviewed changed file: data/species/epiphyllum_oxypetalum.json (the only file in the PR).
  • GitHub Actions at the fixed SHA: test (3.11) passed and test (3.12) passed.
  • Merge state at review time: CONFLICTING / DIRTY.
  • Evidence status at review time: evidence: missing; the PR description contains no original or licensed photo links.

Local verification

Run from a detached worktree at the fixed SHA:

python -m pytest -q
41 passed in 7.90s

git diff 46049dc^ 46049dc --check
exit 0

Repository-wide Ruff is not green, but its failures are pre-existing and unrelated to this one-file JSON change: ruff check . fails on the already-present malformed ai_solution.py, while ruff format --check . reports nine existing Python files. The PR changes none of those files.

Acceptance failures

  1. Species schema is incompatible with the catalog. Required top-level fields id, scientific_name, and tags are absent. The PR uses species instead of id.
  2. Care card is incomplete/incompatible. Required fields summary, temperature_c, toxicity, common_issues, and tips are absent. It uses temperature instead of temperature_c.
  3. Trait sample is missing. data/samples/obs_epiphyllum_oxypetalum.json does not exist in this PR.
  4. Required photo evidence is missing. The bounty requires at least two original or clearly licensed photos in the PR description (or the documented photo directory).
  5. Care command only appears to work because of fallback behavior. Running plantguide care show -s epiphyllum_oxypetalum exits 0 but returns a generated generic card (for example, General care tips for Queen of the Night, temperature_c: 18-27, and an unknown-toxicity fallback), not the submitted JSON values. This does not demonstrate that the new record loaded successfully.
  6. Identifier acceptance fails. For the issue's exact suggested query:
plantguide identify tags --tags "orchid cactus,night bloom,flat stems,tropical"

the top three results are alocasia_zebrina, codiaeum_variegatum, and colocasia_esculenta (all tied at 0.125). epiphyllum_oxypetalum is absent, so the target is not a reasonable top match.
7. Content quality issue. The identification text says “Oval to round leaves on slender stems,” which does not describe the flat, leaf-like stems highlighted by the bounty.

Superseding implementation

PR #319 was merged for the same issue and adds both required files with the expected schema, including five tags and the complete care object. Issue #44 is now closed by both PR references, but #319 is the implementation present on master.

Security/privacy check

No executable code, credentials, private PII, or bundled binary content was added. The main safety concern is the missing toxicity field/disclaimer required by the issue.

Recommended action: close this PR as superseded by #319 (or request a rebase plus the missing schema, sample, evidence, and functional fixes if maintainers still want to consider it).

QA bounty payout identity: github:hualuoz

@yh-liao-07

yh-liao-07 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

This PR has been superseded by #319 (merged). Closing as duplicate.

@yh-liao-07 please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

evidence: missing PR needs screenshot, photo, GIF, or video evidence star: verified Follow mergeos-bounties org + star mergeos + mergeos-contracts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[25 MRG] Species pack: Queen of the Night (epiphyllum_oxypetalum) — photo + care card

3 participants

@yh-liao-07 @TUPM96 @hualuoz