feat: normalize toxicity and add pet-safe filter#340
Open
hualuoz wants to merge 2 commits into
Open
Conversation
hualuoz
marked this pull request as ready for review
July 22, 2026 07:59
Author
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plantguide species list --pet-safewith conservative filtering and a veterinary disclaimerBounty
Why
The catalog currently mixes three toxicity shapes, so callers cannot reliably filter it. Some records also contain both safe and toxic wording. Normalization now guarantees exactly one pet-safety state (
pet_safe,toxic_to_pets, orunknown), with toxicity warnings taking precedence and ambiguous records remaining unknown.User impact
Users can list only explicitly pet-safe catalog entries while uncertain entries are excluded. The output makes clear that catalog flags are informational and should be verified with a veterinarian or trusted toxicology source.
Validation
pytest -q— 59 passedruff check— passedruff format --check— passedplantguide species list --pet-safe— verified against the bundled catalogNo secrets, production keys, or private customer data are included.
Fixes #20