-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added syntex URL #170
base: main
Are you sure you want to change the base?
Added syntex URL #170
Conversation
Updated Threat Intelligence URL to close merill#159
Update Threat Intelligence URL
Added Syntex URL and closes merill#162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Shellgio, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a new URL for Syntex to the commands.csv
file. It also updates the URL for Threat Intelligence (deti) to a new address. This change addresses and closes issue #162.
Highlights
- New URL: Added a new URL for Syntex to the
commands.csv
file. - URL Update: Updated the URL for Threat Intelligence (deti) in the
commands.csv
file.
Changelog
- website/config/commands.csv
- Updated the Threat Intelligence (deti) URL from
https://ti.defender.microsoft.com
tohttps://security.microsoft.com/intel-explorer?referrer=MDTI_STANDALONE_REDIRECT
at line 84. - Added a new entry for Syntex with the URL
https://admin.cloud.microsoft/#/syntex
at line 318.
- Updated the Threat Intelligence (deti) URL from
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A link added, a path defined,
To Syntex's realm, a treasure to find.
Threat Intelligence, a watchful eye,
Its address updated, soaring high.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds a new Syntex URL to the commands list. The changes seem straightforward and address the issue #162. However, I have a few suggestions to improve the data consistency.
Summary of Findings
- Data Consistency: The new entry for Syntex lacks alias and keywords, which are present in other entries. Consider adding appropriate values for these fields to maintain consistency.
Merge Readiness
The pull request introduces a new URL, which is a valuable addition. However, to ensure data consistency and improve searchability, consider adding aliases and keywords for the new entry. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging. I recommend addressing the data consistency issue before merging.
deqp,quarantinepolicies,Quarantine policies,,Defender,https://security.microsoft.com/quarantinePolicies | ||
syntex,,Syntex,,Microsoft 365,https://admin.cloud.microsoft/#/syntex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding aliases and keywords for the Syntex entry to improve searchability and consistency with other entries. For example, syntex,sp,sharepointpremium
for alias and SharePoint Premium, Syntex
for keywords.
syntex,sp|sharepointpremium,Syntex,,Microsoft 365,https://admin.cloud.microsoft/#/syntex
Added Syntex URL and closes #162