Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elk Rendering for Flowcharts does not support Title and arrow styling #4813

Closed
pascha00 opened this issue Sep 4, 2023 · 5 comments · Fixed by #4844
Closed

Elk Rendering for Flowcharts does not support Title and arrow styling #4813

pascha00 opened this issue Sep 4, 2023 · 5 comments · Fixed by #4844

Comments

@pascha00
Copy link

pascha00 commented Sep 4, 2023

Description

Elk Rendering for Flowcharts does not support title and arrow styling.

Steps to reproduce

Use the sample code below.

Screenshots

without Elk rendering :
image

with Elk rendering activated : The Title disappears and the "Master Data" Arrow is plain instead of dotted.
image

Code Sample

---
title: Interfaces for B
---
%%{init: {'flowchart': {'defaultRenderer': 'elk'}}}%%
flowchart LR
A-->|"Guarantee"|B
C-->|"User attributes"|B
C-.->|"Master data"|B
C-->|"Exchange Rate"|B
C-->|"Profit Centers"|B
C-->|"Vendor Partners"|B
C-->|"Work Situation"|B
C-->|"Customer"|B
C-->|"Profit Centers"|B
B-->|"Guarantee"|C

Setup

  • Mermaid version: Live Editor 10.3.0
  • Browser and Version: Chrome

Suggested Solutions

No response

Additional Context

No response

@pascha00 pascha00 added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Sep 4, 2023
@sidharthv96
Copy link
Member

Elk also does not support line length currently.
We need to fix that also.

@sidharthv96 sidharthv96 added Contributor needed Status: Approved Is ready to be worked on Graph: Flow Area: Development Internals: Renderer and removed Status: Triage Needs to be verified, categorized, etc labels Sep 6, 2023
@itsalam
Copy link
Contributor

itsalam commented Sep 8, 2023

Hi, currently taking a crack at this, and it's almost complete but I'm having issues running the precommit linting step as I'm running into memory leaks from the eslint command -- just wondering if anyone here could chime in on how to work with that?

@sidharthv96
Copy link
Member

@itsalam, you can use the git commit -n flag to skip eslint for now.

@itsalam
Copy link
Contributor

itsalam commented Sep 15, 2023

@sidharthv96 cool, just checking if thats fine with you guys, I'll upload in a bit.

@jgreywolf jgreywolf added roadmap items to add to roadmap for auto workflow and removed roadmap items to add to roadmap for auto workflow labels Nov 16, 2023
@bish0polis
Copy link
Contributor

#4844 seems to address this issue perfectly. Is this issue jammed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants