Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence diagram's box line is not visible in dark mode. #5720

Open
samchon opened this issue Aug 19, 2024 · 1 comment · May be fixed by #5735
Open

Sequence diagram's box line is not visible in dark mode. #5720

samchon opened this issue Aug 19, 2024 · 1 comment · May be fixed by #5735
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@samchon
Copy link

samchon commented Aug 19, 2024

Description

I suddenly found a mermaid sequence diagram bug devoping an website.

When declare a box in sequence diagram, its line is visible in the light mode, but not in the dark mode.

It's because the box line's default color is always black even in the dark mode.

Steps to reproduce

  1. Declare a box without custom styling
  2. Change the github style to dark mode
  3. The box line is not visible due to black coloured.

Screenshots

image image

Code Sample

sequenceDiagram
box Client Application
  actor User
  participant Driver as Driver<Listener>
  participant Connector as Communicator (Client)
end
box Server Application
  participant Acceptor as Communicator (Server)
  actor Provider
end
User->>Driver: 1. calls a function
Activate User
Activate Driver
Driver->>Connector: 2. delivers the function call
Activate Connector
Deactivate Driver
Connector-->>Acceptor: 3. sends a protocolized<br/>network message<br/>meaning a function call
Deactivate Connector
Activate Acceptor
Acceptor->>Provider: 4. calls the function
Provider->>Acceptor: 5. returns a value
Acceptor-->>Connector: 6. sends a protocolized<br/>network message<br/>meaning a return value
Deactivate Acceptor
Activate Connector
Connector->>User: 7. delivers the return value
Deactivate Connector
Deactivate User
Loading

https://develop.git.mermaid.live/edit#pako:eNqdk01v2zAMhv8KodMKpBn20Q4wCgNBctxhQNGbLozMpEJtyqPkbGvR_z4psh01zS47SaSph-9LWS_KuIZUpTz9HIgNbSzuBTvNW_cb1q0lDrDq-9YaDNaxZgA0wQk8eJIU9SjBGttjLNyIPZAA-nF39936QExSn1euHTMdObF47bpu4NQhxh9y0yvNxE2WcU-SsGcyStzKGOov0vLZq5PuH-IOtknaj_xk47qus94KPi3BYNt6QNgNbHKvVVwPGGj0PIf5kOa8RsrsqoLPS2ioTXkP4ZFm2hFfMOYjEUN4Tp6_Xkf6ZLKCL0vwUX1S2YsLzrjWPlNzt5WPNVP45eQJOvIe93TMdYRseV-YGmUULQshs7ipY0rlXZQxDbCCr9OwSoOap4I3km-WIBQG4ST6gO1ABfTt6G7_213uMOELc6WR935PU67rdMUVfDu7vX-CL19fgqiF6kg6tE18XS_p_9MqojrSqorbBuVJK82vsQ6H4O7_sFHVDltPCyVu2D_O0dA3ETo-zDH7-hfa8lyB

Setup

  • Mermaid version: Don't know, but just occured in Github markdown content
  • Browser and Version: In every browsers

Suggested Solutions

I think box color should be variable for theme configuration.

@samchon samchon added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Aug 19, 2024
@KawtharAlakri
Copy link

I'd like to work on this.

@KawtharAlakri KawtharAlakri linked a pull request Aug 22, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants