Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Diagram Box in Dark Mode #5735

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

KawtharAlakri
Copy link

@KawtharAlakri KawtharAlakri commented Aug 22, 2024

📑 Summary

This PR introduce change to the sequence diagram box border color in dark mode.
Resolves #5720

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Test Result:
image

Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: b66a3a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Aug 22, 2024
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit b66a3a3
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66cace3d08104d0008b0cebf
😎 Deploy Preview https://deploy-preview-5735--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 1 changed Aug 25, 2024, 6:36 AM

@KawtharAlakri KawtharAlakri changed the title white borders for sequence diagram dark mode Sequence Diagram Box in Dark Mode Aug 22, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 5.21%. Comparing base (2fe5e67) to head (b66a3a3).
Report is 157 commits behind head on develop.

Files Patch % Lines
...kages/mermaid/src/diagrams/common/svgDrawCommon.ts 0.00% 6 Missing ⚠️
packages/mermaid/src/diagrams/sequence/styles.js 0.00% 5 Missing ⚠️
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% 2 Missing ⚠️
packages/mermaid/src/themes/theme-dark.js 0.00% 2 Missing ⚠️
packages/mermaid/src/themes/theme-base.js 0.00% 1 Missing ⚠️
packages/mermaid/src/themes/theme-forest.js 0.00% 1 Missing ⚠️
packages/mermaid/src/themes/theme-neutral.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5735      +/-   ##
==========================================
- Coverage     5.32%   5.21%   -0.12%     
==========================================
  Files          318     322       +4     
  Lines        45148   46103     +955     
  Branches       531     562      +31     
==========================================
  Hits          2402    2402              
- Misses       42746   43701     +955     
Flag Coverage Δ
unit 5.21% <5.26%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../mermaid/src/diagrams/sequence/sequenceRenderer.ts 0.00% <ø> (ø)
packages/mermaid/src/themes/theme-default.js 94.37% <100.00%> (ø)
packages/mermaid/src/themes/theme-base.js 3.80% <0.00%> (-0.02%) ⬇️
packages/mermaid/src/themes/theme-forest.js 3.80% <0.00%> (ø)
packages/mermaid/src/themes/theme-neutral.js 4.55% <0.00%> (ø)
packages/mermaid/src/diagrams/sequence/svgDraw.js 0.00% <0.00%> (ø)
packages/mermaid/src/themes/theme-dark.js 2.73% <0.00%> (ø)
packages/mermaid/src/diagrams/sequence/styles.js 0.00% <0.00%> (ø)
...kages/mermaid/src/diagrams/common/svgDrawCommon.ts 0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence diagram's box line is not visible in dark mode.
1 participant