Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized timeline definitions #4711

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Yokozuna59
Copy link
Member

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

@Yokozuna59 Yokozuna59 self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #4711 (e6d8bfd) into develop (b85c011) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4711      +/-   ##
===========================================
- Coverage    77.04%   77.02%   -0.02%     
===========================================
  Files          144      144              
  Lines        14565    14565              
  Branches       586      592       +6     
===========================================
- Hits         11221    11219       -2     
  Misses        3233     3233              
- Partials       111      113       +2     
Flag Coverage Δ
e2e 83.88% <100.00%> (-0.02%) ⬇️
unit 45.32% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ckages/mermaid/src/diagrams/timeline/timelineDb.ts 91.48% <ø> (ø)
...es/mermaid/src/diagrams/timeline/timelineStyles.ts 100.00% <ø> (ø)
...s/mermaid/src/diagram-api/diagram-orchestration.ts 39.53% <100.00%> (ø)
.../mermaid/src/diagrams/timeline/timelineDetector.ts 90.90% <100.00%> (ø)
...s/mermaid/src/diagrams/timeline/timelineDiagram.ts 100.00% <100.00%> (ø)

@Yokozuna59
Copy link
Member Author

The current timeline files need more work and a lot of breaking changes, I'll be working on journey instead for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants