-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XYChart's nav link in the docs template #5014
Conversation
The site gives 404 with xychart but navigates correctly with xyChart
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5014 +/- ##
===========================================
+ Coverage 79.37% 79.64% +0.27%
===========================================
Files 164 164
Lines 13820 13820
Branches 693 693
===========================================
+ Hits 10969 11007 +38
+ Misses 2702 2664 -38
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
We do have a Link Checker GitHub Action that normally checks to see if all our links are working, but it currently only checks Markdown files. Maybe it's worth us running it on the built-website too so it checks links in the template too.
@Abrifq, Thank you for the contribution! |
I'm glad to help! By the way, do you know anyone that can review/merge mermaid-js/mermaid-live-editor#1335 |
Hmmmm, I'm not too familiar with Svelte or the I think the mermaid-live-editor project only has a single maintainer currently, so PRs there might be a bit slower to review. |
📑 Summary
Brief description about the content of your PR.
The site gives 404 with
xychart
but navigates correctly withxyChart
Resolves #4984
📏 Design Decisions
N/A
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch