Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart: Apply nodeSpacing/rankSpacing config to subgraphs #5183

Commits on Jan 7, 2024

  1. Resolved issue with subgraph configuration

    This commit resolves the issues with subgraph configuration, specifically for nodeSpacing and rankSpacing. This commit additionally adds an example graph to the `flowchart.html` to demonstrate this resolution. This commit resolves mermaid-js#3258
    rowanfr committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    beb308c View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Removed unnecessary function

    Removed unnecessary function to pass test coverage CI
    rowanfr committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3bbd8fe View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    65fd3a3 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    36c84b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Update demos/flowchart.html

    Co-authored-by: Nikolay Rozhkov <[email protected]>
    rowanfr and nirname authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    565f154 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    a5ecc7a View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Fixed configuration override on subgraphs

    There was an issue with overriding the subgraphs with the main graphs direction which this commit fixes. It only overrides `rankdir` on the `setGraph` function so that the subgraph preserves it's `rankdir`. There is likely a better way of doing this by modifying the initialization of subgraph configuration to match the main graph when it comes to other elements in the JSON object which composes the graph label.
    
    As we modify the codebase this added line can be deprecated once we add more modular control to subgraphs such as allowing custom spacing or configurations for them. As `rankdir` is the only thing one can set with the `direction` keyword that is the only variable being overwritten for now.
    rowanfr committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f693084 View commit details
    Browse the repository at this point in the history
  2. Fixed linting error

    rowanfr committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0c7e2e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    3fad11e View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    ff5240c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a1a38b View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Configuration menu
    Copy the full SHA
    fa201ad View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    140645b View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    82c4052 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Update packages/mermaid/src/dagre-wrapper/index.js

    The code setting the `ranksep` and `nodesep` to subgraphs was made cleaner and more legible while maintaining the intended functionality of subgraph spacing
    
    Co-authored-by: Alois Klink <[email protected]>
    rowanfr and aloisklink authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0ce33cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5935e27 View commit details
    Browse the repository at this point in the history
  3. Added E2E testing for spacing

    This adds E2E testing for spacing and provides more appropriate comments for the changes made to `index.js`
    rowanfr committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3602191 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    0cb365c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8862d63 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    5ccdb6f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    ae29dd1 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    424d988 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de4ad76 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Configuration menu
    Copy the full SHA
    77ba19c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    4feb2e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    d0a0085 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f556fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b78f16e View commit details
    Browse the repository at this point in the history
  4. Add extra test

    sidharthv96 committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    dbb69ad View commit details
    Browse the repository at this point in the history