-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flowchart: Apply nodeSpacing
/rankSpacing
config to subgraphs
#5183
Merged
sidharthv96
merged 29 commits into
mermaid-js:develop
from
rowanfr:origin/3258_Flowchart_nodeSpacing_Subgraph
Mar 23, 2024
Merged
Flowchart: Apply nodeSpacing
/rankSpacing
config to subgraphs
#5183
sidharthv96
merged 29 commits into
mermaid-js:develop
from
rowanfr:origin/3258_Flowchart_nodeSpacing_Subgraph
Mar 23, 2024
Commits on Jan 7, 2024
-
Resolved issue with subgraph configuration
This commit resolves the issues with subgraph configuration, specifically for nodeSpacing and rankSpacing. This commit additionally adds an example graph to the `flowchart.html` to demonstrate this resolution. This commit resolves mermaid-js#3258
Configuration menu - View commit details
-
Copy full SHA for beb308c - Browse repository at this point
Copy the full SHA beb308cView commit details
Commits on Jan 8, 2024
-
Removed unnecessary function to pass test coverage CI
Configuration menu - View commit details
-
Copy full SHA for 3bbd8fe - Browse repository at this point
Copy the full SHA 3bbd8feView commit details
Commits on Jan 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65fd3a3 - Browse repository at this point
Copy the full SHA 65fd3a3View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 36c84b3 - Browse repository at this point
Copy the full SHA 36c84b3View commit details
Commits on Jan 14, 2024
-
Co-authored-by: Nikolay Rozhkov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 565f154 - Browse repository at this point
Copy the full SHA 565f154View commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a5ecc7a - Browse repository at this point
Copy the full SHA a5ecc7aView commit details
Commits on Jan 16, 2024
-
Fixed configuration override on subgraphs
There was an issue with overriding the subgraphs with the main graphs direction which this commit fixes. It only overrides `rankdir` on the `setGraph` function so that the subgraph preserves it's `rankdir`. There is likely a better way of doing this by modifying the initialization of subgraph configuration to match the main graph when it comes to other elements in the JSON object which composes the graph label. As we modify the codebase this added line can be deprecated once we add more modular control to subgraphs such as allowing custom spacing or configurations for them. As `rankdir` is the only thing one can set with the `direction` keyword that is the only variable being overwritten for now.
Configuration menu - View commit details
-
Copy full SHA for f693084 - Browse repository at this point
Copy the full SHA f693084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c7e2e2 - Browse repository at this point
Copy the full SHA 0c7e2e2View commit details
Commits on Jan 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3fad11e - Browse repository at this point
Copy the full SHA 3fad11eView commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ff5240c - Browse repository at this point
Copy the full SHA ff5240cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a1a38b - Browse repository at this point
Copy the full SHA 6a1a38bView commit details
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa201ad - Browse repository at this point
Copy the full SHA fa201adView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 140645b - Browse repository at this point
Copy the full SHA 140645bView commit details
Commits on Jan 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 82c4052 - Browse repository at this point
Copy the full SHA 82c4052View commit details
Commits on Feb 28, 2024
-
Update packages/mermaid/src/dagre-wrapper/index.js
The code setting the `ranksep` and `nodesep` to subgraphs was made cleaner and more legible while maintaining the intended functionality of subgraph spacing Co-authored-by: Alois Klink <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ce33cb - Browse repository at this point
Copy the full SHA 0ce33cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5935e27 - Browse repository at this point
Copy the full SHA 5935e27View commit details -
This adds E2E testing for spacing and provides more appropriate comments for the changes made to `index.js`
Configuration menu - View commit details
-
Copy full SHA for 3602191 - Browse repository at this point
Copy the full SHA 3602191View commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0cb365c - Browse repository at this point
Copy the full SHA 0cb365cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8862d63 - Browse repository at this point
Copy the full SHA 8862d63View commit details
Commits on Mar 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ccdb6f - Browse repository at this point
Copy the full SHA 5ccdb6fView commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae29dd1 - Browse repository at this point
Copy the full SHA ae29dd1View commit details
Commits on Mar 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 424d988 - Browse repository at this point
Copy the full SHA 424d988View commit details -
Configuration menu - View commit details
-
Copy full SHA for de4ad76 - Browse repository at this point
Copy the full SHA de4ad76View commit details
Commits on Mar 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77ba19c - Browse repository at this point
Copy the full SHA 77ba19cView commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4feb2e6 - Browse repository at this point
Copy the full SHA 4feb2e6View commit details
Commits on Mar 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d0a0085 - Browse repository at this point
Copy the full SHA d0a0085View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f556fa - Browse repository at this point
Copy the full SHA 3f556faView commit details -
Configuration menu - View commit details
-
Copy full SHA for b78f16e - Browse repository at this point
Copy the full SHA b78f16eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbb69ad - Browse repository at this point
Copy the full SHA dbb69adView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.