Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4661 gantt customize days of weekend #5358

Conversation

Ronid1
Copy link
Contributor

@Ronid1 Ronid1 commented Mar 4, 2024

📑 Summary

Added configuration for weekend start day. Weekend can either start on Friday or Saturday, with Saturday remaining the default.

Resolves #4661

📏 Design Decisions

Only added configurations for friday and saturday since these are the days that weekends traditionally start on. In either case, the weekend is 2 days long. Maintained the lowercase standards from other components of Gantt.

configuration can be added to the graph using this line:
weekend friday
or
weekend saturday

If the weekend keyword is not used, the default will be saturday

📋 Tasks

Make sure you

@github-actions github-actions bot added the Type: Enhancement New feature or request label Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 07117b4
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65fd565d5b6f310008c95be1

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.79%. Comparing base (10fb856) to head (07117b4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5358      +/-   ##
===========================================
+ Coverage    44.67%   44.79%   +0.12%     
===========================================
  Files           25       25              
  Lines         5341     5353      +12     
  Branches        27       27              
===========================================
+ Hits          2386     2398      +12     
  Misses        2954     2954              
  Partials         1        1              
Flag Coverage Δ
unit 44.79% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 77.47% <100.00%> (+0.33%) ⬆️

@Ronid1 Ronid1 marked this pull request as ready for review March 5, 2024 19:55
Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

packages/mermaid/src/diagrams/gantt/ganttDb.js Outdated Show resolved Hide resolved
packages/mermaid/src/diagrams/gantt/ganttDb.js Outdated Show resolved Hide resolved
@sidharthv96
Copy link
Member

sidharthv96 commented Mar 6, 2024

@Ronid1 if you could try converting the remaining JS files into TS (in different PRs), that would be very helpful. It'll also help catch many underlying issues as well.

You can get started by removing // @ts-nocheck comments from some existing TS files.

@Ronid1
Copy link
Contributor Author

Ronid1 commented Mar 6, 2024

@sidharthv96 updated according to your review. Not really sure about the error I'm getting in the ci, would appreciate help with it.
And yes, I could definitely try to tackle TS migration in a different PR :)

@sidharthv96 sidharthv96 enabled auto-merge March 22, 2024 09:58
@sidharthv96 sidharthv96 added this pull request to the merge queue Mar 22, 2024
Merged via the queue into mermaid-js:develop with commit d6c1a59 Mar 22, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set new weekends when weekday is set
2 participants