-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/4661 gantt customize days of weekend #5358
Feature/4661 gantt customize days of weekend #5358
Conversation
❌ Deploy Preview for mermaid-js failed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5358 +/- ##
===========================================
+ Coverage 44.67% 44.79% +0.12%
===========================================
Files 25 25
Lines 5341 5353 +12
Branches 27 27
===========================================
+ Hits 2386 2398 +12
Misses 2954 2954
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…Feature/4661_gantt_customize_days_of_weekend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@Ronid1 if you could try converting the remaining JS files into TS (in different PRs), that would be very helpful. It'll also help catch many underlying issues as well. You can get started by removing |
…feature/4661_gantt_customize_days_of_weekend
@sidharthv96 updated according to your review. Not really sure about the error I'm getting in the ci, would appreciate help with it. |
d6c1a59
📑 Summary
Added configuration for weekend start day. Weekend can either start on Friday or Saturday, with Saturday remaining the default.
Resolves #4661
📏 Design Decisions
Only added configurations for
friday
andsaturday
since these are the days that weekends traditionally start on. In either case, the weekend is 2 days long. Maintained the lowercase standards from other components of Gantt.configuration can be added to the graph using this line:
weekend friday
or
weekend saturday
If the
weekend
keyword is not used, the default will be saturday📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch