fix: long strings in markdown in flowcharts in firefox #5648
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Bug / Error
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5648 +/- ##
=======================================
Coverage 5.86% 5.86%
=======================================
Files 274 273 -1
Lines 41087 41080 -7
Branches 488 512 +24
=======================================
Hits 2408 2408
+ Misses 38679 38672 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Fixes an issue on firefox where long strings in markdown in flowchart diagrams would overflow and not render correctly.
Resolves #5646
📏 Design Decisions
This problem resulted since the width and height inline styles were registering as
0when thepxunits weren't specified in Firefox. The newly assigned bbox after switching the div todisplay: tabledidn't have a width or height either on Firefox only. This PR instead adds the height as a style upto where thewidthandheightattributes are assigned on Firefox. I am not sure if the inline styles are needed because the attributes exist, but I kept them there for now.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch