Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5237 Review Updates #5670

Merged
merged 5 commits into from
Aug 20, 2024
Merged

5237 Review Updates #5670

merged 5 commits into from
Aug 20, 2024

Conversation

sidharthv96
Copy link
Member

Internal

Copy link

argos-ci bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 46 changed Aug 20, 2024, 7:24 AM

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 5.22%. Comparing base (c5eb07c) to head (4e40f29).
Report is 39 commits behind head on develop.

Files Patch % Lines
packages/mermaid/src/diagrams/state/dataFetcher.js 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5670   +/-   ##
=======================================
  Coverage     5.22%   5.22%           
=======================================
  Files          322     323    +1     
  Lines        46201   46180   -21     
  Branches       561     537   -24     
=======================================
  Hits          2415    2415           
+ Misses       43786   43765   -21     
Flag Coverage Δ
unit 5.22% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/state/dataFetcher.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Base automatically changed from 5237-unified-layout-common-renderer to develop August 12, 2024 12:38
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 4e40f29
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c441f6bc574b0008b4b9ec
😎 Deploy Preview https://deploy-preview-5670--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 merged commit 1956d3d into develop Aug 20, 2024
28 of 29 checks passed
@sidharthv96 sidharthv96 deleted the sidv/5237_review branch August 20, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant