-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add icon explanations #5681
base: develop
Are you sure you want to change the base?
Docs: add icon explanations #5681
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5681 +/- ##
=======================================
Coverage 5.85% 5.85%
=======================================
Files 274 274
Lines 41112 41112
Branches 488 488
=======================================
Hits 2408 2408
Misses 38704 38704
Flags with carried forward coverage won't be shown. Click here to find out more. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the note be moved to a more general page, so that we don't have to duplicate it inside each diagram pages?
Thank you for the feedback, @sidharthv96 . |
Hi @sidharthv96 , I have updated the PR. Description
Please review the changes and let me know if there are any further adjustments needed. |
I meant having the note once in a general page, like the main readme, so that we don't have to duplicate the notes in every page. If we do need to duplicate (which I don't think we should), we should use something like vitepress's footer, so that we can inject it in one place, rather than importing in every diagram. Also, because we don't use only vitest, including should be done using our custom tag |
Hi @sidharthv96, I've explored two approaches to include the notes without duplicating them in every diagram page: Linking to a General Notes Page:
Example code and screenshot below: Using the custom include method:
Example code and screenshot below: Please let me know which approach you prefer or if there are any other adjustments needed. |
What I don't understand is why we need the note under every diagram. And whether we should change the icon to something else, so that it's obvious without an explanation. |
📑 Summary
Added explanations for icons used in the documentation.
Resolves #5346
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch