Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(er): allow multi-line relationship labels #5711

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

NicolasNewman
Copy link
Collaborator

📑 Summary

Allow line breaks to be added to entity relationship labels (using the token <br />)

image

📏 Design Decisions

  • If the token indicating a line break is present, add tspans into the text element per each line of text

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
    (I'll add one if/once this feature gets approval)
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🔖 targeted develop branch

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit dbd4658
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66cb6fa7b2d28a00088db2a4
😎 Deploy Preview https://deploy-preview-5711--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 5.20%. Comparing base (5ba5e30) to head (dbd4658).
Report is 16 commits behind head on develop.

Files Patch % Lines
packages/mermaid/src/diagrams/er/erRenderer.js 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5711      +/-   ##
==========================================
- Coverage     5.21%   5.20%   -0.01%     
==========================================
  Files          322     322              
  Lines        46083   46108      +25     
  Branches       561     561              
==========================================
  Hits          2402    2402              
- Misses       43681   43706      +25     
Flag Coverage Δ
unit 5.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/er/erRenderer.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 added Aug 25, 2024, 6:04 PM

Copy link

changeset-bot bot commented Aug 24, 2024

🦋 Changeset detected

Latest commit: dbd4658

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolasNewman code LGTM. Can you please add a visual test?

You can use the same code in demo, having both <br/> and <br /> would be good.

@sidharthv96 sidharthv96 added this pull request to the merge queue Aug 26, 2024
Merged via the queue into mermaid-js:develop with commit e3b2a69 Aug 26, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants