-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(er): allow multi-line relationship labels #5711
feat(er): allow multi-line relationship labels #5711
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5711 +/- ##
==========================================
- Coverage 5.21% 5.20% -0.01%
==========================================
Files 322 322
Lines 46083 46108 +25
Branches 561 561
==========================================
Hits 2402 2402
- Misses 43681 43706 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
🦋 Changeset detectedLatest commit: dbd4658 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NicolasNewman code LGTM. Can you please add a visual test?
You can use the same code in demo, having both <br/>
and <br />
would be good.
📑 Summary
Allow line breaks to be added to entity relationship labels (using the token
<br />
)📏 Design Decisions
📋 Tasks
Make sure you
(I'll add one if/once this feature gets approval)
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch