-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!(sankey): default to useMaxWidth
true
#5724
refactor!(sankey): default to useMaxWidth
true
#5724
Conversation
All other diagrams (with the exception of Sankey) default to `true`. BREAKING CHANGE: Change the default value of `useMaxWidth` for gitgraphs to `true`.
All other diagrams default to `useMaxWidth` `true`. BREAKING CHANGE: Change the default value of `useMaxWidth` for sankey diagrams to `true`.
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5724 +/- ##
==========================================
- Coverage 5.22% 5.19% -0.03%
==========================================
Files 323 323
Lines 46212 46199 -13
Branches 537 537
==========================================
- Hits 2415 2402 -13
Misses 43797 43797
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📑 Summary
Note
I've stacked this PR on top of the following to avoid merge conflicts. Please merge them first:
useMaxWidth
true #5723Change the default value for
sankey.useMaxWidth
totrue
, as all mermaid diagrams default touseMaxWidth
astrue
, with the exception of git graphs (which will be fixed in #5723).The documentation currently says it defaults to
true
, so changing this matches the documentation. See:mermaid/packages/mermaid/src/schemas/config.schema.yaml
Lines 306 to 312 in d4d7ca7
BREAKING CHANGE: Changes the default value of
useMaxWidth
for sankey diagrams totrue
. This is technically a breaking change, but considering that most of the other diagrams default totrue
, I think this is unlikely to impact anybody.However, if anybody does want the old behavior, they can always explicitly set
{ sankey: { useMaxWidth: false } }
.📏 Design Decisions
N/A
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch