-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support flowchart-elk to use layout: elk #5729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for mermaid-js failed.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5729 +/- ##
==========================================
+ Coverage 5.20% 5.32% +0.12%
==========================================
Files 323 317 -6
Lines 46172 45066 -1106
Branches 537 531 -6
==========================================
Hits 2402 2402
+ Misses 43770 42664 -1106
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* develop: chore: Update pnpm and lockfile
sidharthv96
force-pushed
the
elk-migration
branch
from
August 21, 2024 09:05
f2bb637
to
58aa4c4
Compare
knsv
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Removes
@mermaid-js/flowchart-elk
package and replaces it with@mermaid-js/layout-elk
.The
@mermaid-js/flowchart-elk
was not officially released yet, only RC releases were made.To use the new package,
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch