Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flowchart-elk to use layout: elk #5729

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Support flowchart-elk to use layout: elk #5729

merged 10 commits into from
Aug 21, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Aug 21, 2024

📑 Summary

Removes @mermaid-js/flowchart-elk package and replaces it with @mermaid-js/layout-elk.
The @mermaid-js/flowchart-elk was not officially released yet, only RC releases were made.

To use the new package,

import elkLayouts from '@mermaid-js/layout-elk';
import mermaid from 'mermaid';

mermaid.registerLayoutLoaders(elkLayouts);

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 797877b
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c5c74d312200000866b55f

Copy link

argos-ci bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 46 changed Aug 21, 2024, 11:08 AM

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 5.32%. Comparing base (0cc7eb7) to head (797877b).
Report is 27 commits behind head on develop.

Files Patch % Lines
packages/mermaid/src/rendering-util/render.ts 0.00% 16 Missing ⚠️
...ages/mermaid/src/diagrams/flowchart/flowDiagram.ts 0.00% 7 Missing ⚠️
.../src/diagrams/flowchart/flowRenderer-v3-unified.ts 0.00% 7 Missing ⚠️
.../mermaid/src/diagrams/flowchart/flowDetector-v2.ts 0.00% 6 Missing ⚠️
...ges/mermaid/src/diagrams/flowchart/elk/detector.ts 0.00% 4 Missing ⚠️
packages/mermaid-layout-elk/src/layouts.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5729      +/-   ##
==========================================
+ Coverage     5.20%   5.32%   +0.12%     
==========================================
  Files          323     317       -6     
  Lines        46172   45066    -1106     
  Branches       537     531       -6     
==========================================
  Hits          2402    2402              
+ Misses       43770   42664    -1106     
Flag Coverage Δ
unit 5.32% <0.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid-layout-elk/src/layouts.ts 0.00% <0.00%> (ø)
...ges/mermaid/src/diagrams/flowchart/elk/detector.ts 0.00% <0.00%> (ø)
.../mermaid/src/diagrams/flowchart/flowDetector-v2.ts 0.00% <0.00%> (ø)
...ages/mermaid/src/diagrams/flowchart/flowDiagram.ts 0.00% <0.00%> (ø)
.../src/diagrams/flowchart/flowRenderer-v3-unified.ts 0.00% <0.00%> (ø)
packages/mermaid/src/rendering-util/render.ts 0.00% <0.00%> (ø)

* develop:
  chore: Update pnpm and lockfile
@sidharthv96 sidharthv96 marked this pull request as ready for review August 21, 2024 09:29
@sidharthv96 sidharthv96 requested a review from knsv August 21, 2024 09:40
@knsv knsv merged commit f4097df into develop Aug 21, 2024
24 of 25 checks passed
@knsv knsv deleted the elk-migration branch August 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants