Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout-elk types #5758

Merged
merged 2 commits into from
Aug 24, 2024
Merged

fix: layout-elk types #5758

merged 2 commits into from
Aug 24, 2024

Conversation

sidharthv96
Copy link
Member

📑 Summary

Correct the path for types

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Aug 24, 2024

🦋 Changeset detected

Latest commit: 501a55d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mermaid-js/layout-elk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 501a55d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c97c28fdf9980008b2e376
😎 Deploy Preview https://deploy-preview-5758--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 merged commit 1e35341 into develop Aug 24, 2024
21 of 23 checks passed
@sidharthv96 sidharthv96 deleted the sidv/fixTypes branch August 24, 2024 06:23
Copy link

argos-ci bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected 2 failures Aug 24, 2024, 6:34 AM

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.21%. Comparing base (a10f469) to head (501a55d).
Report is 19 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5758   +/-   ##
=======================================
  Coverage     5.21%   5.21%           
=======================================
  Files          323     322    -1     
  Lines        46094   46083   -11     
  Branches       536     561   +25     
=======================================
  Hits          2402    2402           
+ Misses       43692   43681   -11     
Flag Coverage Δ
unit 5.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@github-actions github-actions bot mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant