Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use corepack to install pnpm #5763

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Aug 24, 2024

📑 Summary

Uses corepack to install pnpm in Dockerfile
Defines a workflow to validate Dockerfile

Closes #5754
Closes #5755

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Aug 24, 2024

⚠️ No Changeset found

Latest commit: ed352de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit ed352de
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c9e954308bd90008627c93
😎 Deploy Preview https://deploy-preview-5763--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.21%. Comparing base (4b195d1) to head (ed352de).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5763   +/-   ##
=======================================
  Coverage     5.20%   5.21%           
=======================================
  Files          323     322    -1     
  Lines        46105   46094   -11     
  Branches       536     561   +25     
=======================================
  Hits          2402    2402           
+ Misses       43703   43692   -11     
Flag Coverage Δ
unit 5.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@mmorel-35 mmorel-35 force-pushed the dockerfile branch 3 times, most recently from 3f2b752 to b1f3822 Compare August 24, 2024 08:38
@mmorel-35 mmorel-35 marked this pull request as ready for review August 24, 2024 08:42
Copy link

argos-ci bot commented Aug 24, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Aug 24, 2024, 9:44 PM

@mmorel-35 mmorel-35 changed the title Create rootless Dockerfile chore: create rootless Dockerfile Aug 24, 2024
@mmorel-35
Copy link
Contributor Author

Hi @kairi003,

Would like to have a look as this shall cover the issue you raised ?

@sidharthv96 sidharthv96 requested a review from nirname August 24, 2024 09:14
@mmorel-35 mmorel-35 force-pushed the dockerfile branch 2 times, most recently from 0e996ae to 8b007d7 Compare August 24, 2024 11:25
@mmorel-35 mmorel-35 changed the title chore: create rootless Dockerfile chore: use corepack to install pnpm Aug 24, 2024
@mmorel-35 mmorel-35 force-pushed the dockerfile branch 6 times, most recently from 333ec0e to d54a3a0 Compare August 24, 2024 11:33
@mmorel-35 mmorel-35 added this pull request to the merge queue Aug 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2024
@mmorel-35 mmorel-35 enabled auto-merge August 24, 2024 14:08
@mmorel-35 mmorel-35 added this pull request to the merge queue Aug 24, 2024
Merged via the queue into mermaid-js:develop with commit 2f1cfe0 Aug 24, 2024
19 checks passed
@mmorel-35 mmorel-35 deleted the dockerfile branch August 24, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wget installation fails on Alpine during Dockerfile build
2 participants