Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5782 fix: adding backwards compatability for defaultRenderer directive #5786

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Aug 28, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #5782

📏 Design Decisions

Apply defaultRenderer configuration to layout for backwards compatability.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 011c036

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 011c036
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66cf0551deaf35000827680d
😎 Deploy Preview https://deploy-preview-5786--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 5.20%. Comparing base (8c8ed57) to head (011c036).
Report is 2 commits behind head on develop.

Files Patch % Lines
.../mermaid/src/diagrams/flowchart/flowDetector-v2.ts 0.00% 5 Missing ⚠️
...rc/rendering-util/layout-algorithms/dagre/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5786      +/-   ##
==========================================
- Coverage     5.20%   5.20%   -0.01%     
==========================================
  Files          322     322              
  Lines        46129   46130       +1     
  Branches       561     561              
==========================================
  Hits          2402    2402              
- Misses       43727   43728       +1     
Flag Coverage Δ
unit 5.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/rendering-util/layout-algorithms/dagre/index.js 0.00% <0.00%> (ø)
.../mermaid/src/diagrams/flowchart/flowDetector-v2.ts 0.00% <0.00%> (ø)

Copy link

argos-ci bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Aug 28, 2024, 11:21 AM

@ashishjain0512 ashishjain0512 merged commit 0bd0076 into develop Aug 28, 2024
22 checks passed
@ashishjain0512 ashishjain0512 deleted the 5782_supporting_defaultRenderer branch August 28, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elk renderer dont work in mermaid 11.0.2 version
2 participants