Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Flowchart Shapes (with new syntax) #5825

Merged
merged 256 commits into from
Oct 3, 2024
Merged

New Flowchart Shapes (with new syntax) #5825

merged 256 commits into from
Oct 3, 2024

Conversation

ashishjain0512
Copy link
Collaborator

📑 Summary

This pull request introduces several new flowchart shapes along with their test, updates to the configuration files, and improvements to the documentation.

**The most important changes include a guide for other contributors on how to add a new custom shape for flowcharts.

New Tests and Configurations:

Configuration Updates:

Documentation Enhancements:

  • docs/adding_new_shape/Readme.md: Added detailed documentation on the available utilities for creating new shapes, instructions for adding new shapes, and information on running Cypress tests.

These changes collectively enhance the robustness of the flowchart rendering capabilities and provide clear guidelines for extending the shape library.
Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@mermaid-js mermaid-js deleted a comment from argos-ci bot Oct 1, 2024
@sidharthv96 sidharthv96 enabled auto-merge October 3, 2024 07:40
@sidharthv96 sidharthv96 disabled auto-merge October 3, 2024 11:33
@sidharthv96 sidharthv96 merged commit 02cf111 into develop Oct 3, 2024
24 checks passed
@sidharthv96 sidharthv96 deleted the knsv/new-shapes branch October 3, 2024 11:33
Copy link

mermaid-bot bot commented Oct 3, 2024

@ashishjain0512, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants