Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation about merging blocks horizontally (Resolves #5836) #5916

Conversation

iSparsh
Copy link
Contributor

@iSparsh iSparsh commented Oct 2, 2024

📑 Summary

  • Added section about merging blocks horizontally by setting the column width to 1.
  • Shown using an example of nested blocks.

Resolves #5836

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: d50a6cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d50a6cf
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66fd89ba9ad8ca000884f790
😎 Deploy Preview https://deploy-preview-5916--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 2, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5916
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5916
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5916
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5916

commit: d50a6cf

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.00%. Comparing base (a5559c6) to head (d50a6cf).
Report is 27 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5916   +/-   ##
=======================================
  Coverage     5.00%   5.00%           
=======================================
  Files          338     337    -1     
  Lines        48220   48209   -11     
  Branches       551     576   +25     
=======================================
  Hits          2413    2413           
+ Misses       45807   45796   -11     
Flag Coverage Δ
unit 5.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

argos-ci bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Oct 2, 2024, 6:09 PM

@sidharthv96 sidharthv96 added this pull request to the merge queue Oct 3, 2024
Merged via the queue into mermaid-js:develop with commit c7382af Oct 3, 2024
21 checks passed
Copy link

mermaid-bot bot commented Oct 3, 2024

@iSparsh, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

@PHHENS
Copy link

PHHENS commented Oct 3, 2024

Dear developper,
I did not ask how to stack block vertically, but how to MERGE block vertically :
several block becoming one.
+----+ +----+
| | | |
| | +----+
| | +----+
| | | |
+----+ +----+

Thanks.

@iSparsh
Copy link
Contributor Author

iSparsh commented Oct 3, 2024

@PHHENS sorry, I'm not sure what you mean by that. I'm pretty sure you can use the nested blocks to "merge" blocks (so that they act as one block) as is shown in the first example on here. You can make it vertical by the documentation I have added. Please let me know if I am misunderstanding you! It would be helpful if you could post a diagram of what you want to accomplish through images.

@PHHENS
Copy link

PHHENS commented Oct 4, 2024

Sorry for the bad ascii schematic (some spaces disappeared). Find here an schematic :
VerticallyMergedBlocks
Thanks for your interest and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid Block Diagram
3 participants