Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quadrant chart supports unicode characters #5943

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

liyifa-efan
Copy link

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: d127845

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit d127845
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6704f7b3b380fe0008a081c1
😎 Deploy Preview https://deploy-preview-5943--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5943
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5943
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5943
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5943

commit: d127845

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.67%. Comparing base (3ac93af) to head (d127845).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5943      +/-   ##
==========================================
- Coverage     4.67%   4.67%   -0.01%     
==========================================
  Files          372     373       +1     
  Lines        51669   51680      +11     
  Branches       611     586      -25     
==========================================
  Hits          2414    2414              
- Misses       49255   49266      +11     
Flag Coverage Δ
unit 4.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

argos-ci bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ Auto-approved build - Oct 8, 2024, 9:21 AM

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a standardised method of handling unicode, without adding character sets to jison, by wrapping the text in "". We should follow the same here.

@liyifa-efan
Copy link
Author

We have a standardised method of handling unicode, without adding character sets to jison, by wrapping the text in "". We should follow the same here.

Thank you for your response. I am trying to resolve the issue with "AI-generated mermaid diagrams," where the AI consistently fails to follow instructions to place Chinese characters or special characters within double quotes. So, I am attempting to address this within the mermaid code itself. However, if you believe it is unnecessary to merge, I respect your decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants