-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quadrant chart supports unicode characters #5943
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5943 +/- ##
==========================================
- Coverage 4.67% 4.67% -0.01%
==========================================
Files 372 373 +1
Lines 51669 51680 +11
Branches 611 586 -25
==========================================
Hits 2414 2414
- Misses 49255 49266 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a standardised method of handling unicode, without adding character sets to jison, by wrapping the text in ""
. We should follow the same here.
Thank you for your response. I am trying to resolve the issue with "AI-generated mermaid diagrams," where the AI consistently fails to follow instructions to place Chinese characters or special characters within double quotes. So, I am attempting to address this within the mermaid code itself. However, if you believe it is unnecessary to merge, I respect your decision. |
📑 Summary
Brief description about the content of your PR.
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.