Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(architecture): update icon name for database in exemple #5951

Conversation

gbremond
Copy link
Contributor

📑 Summary

Brief description about the content of your PR.

Resolves #5949

📏 Design Decisions

Documentation changed.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 2c31a59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 2c31a59
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6707ec14b49f2a0008177694
😎 Deploy Preview https://deploy-preview-5951--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5951
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5951
pnpm add https://pkg.pr.new/mermaid-js/mermaid@5951
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5951

commit: 2c31a59

@gbremond gbremond force-pushed the docs/5949_update-icon-name-for-database branch from 95dd901 to e38bd5b Compare October 10, 2024 14:10
Copy link

argos-ci bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Oct 10, 2024, 3:10 PM

@gbremond gbremond force-pushed the docs/5949_update-icon-name-for-database branch from e38bd5b to 4f97c8c Compare October 10, 2024 14:15
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.64%. Comparing base (f859772) to head (2c31a59).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5951      +/-   ##
==========================================
- Coverage     4.64%   4.64%   -0.01%     
==========================================
  Files          374     375       +1     
  Lines        51965   51976      +11     
  Branches       613     587      -26     
==========================================
  Hits          2414    2414              
- Misses       49551   49562      +11     
Flag Coverage Δ
unit 4.64% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

docs/syntax/architecture.md Outdated Show resolved Hide resolved
@sidharthv96 sidharthv96 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into mermaid-js:develop with commit 742531a Oct 11, 2024
22 checks passed
Copy link

mermaid-bot bot commented Oct 11, 2024

@gbremond, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Architecture documentation error citing db icon instead of database
2 participants