-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: TypeScript improvements to packages/mermaid/src/rendering-util/rendering-elements
#5974
refactor: TypeScript improvements to packages/mermaid/src/rendering-util/rendering-elements
#5974
Commits on Oct 17, 2024
-
refactor: improve types of
shapes
Instead of being a `Record<string, ShapeHandler>`, the type now knows every key in the variable.
Configuration menu - View commit details
-
Copy full SHA for cfe7cce - Browse repository at this point
Copy the full SHA cfe7cceView commit details -
refactor: correct shapes types
All of the shapes in `packages/mermaid/src/rendering-util/rendering-elements/shapes/` use `D3.Selection`s as input parameters and as return parameters. Although, for some reason, passing them to roughjs seems to work?
Configuration menu - View commit details
-
Copy full SHA for 9afb181 - Browse repository at this point
Copy the full SHA 9afb181View commit details -
refactor: convert
rendering-elements/nodes
to TSConvert the `packages/mermaid/src/rendering-util/rendering-elements/nodes.js` file to TypeScript at `packages/mermaid/src/rendering-util/rendering-elements/nodes.ts`
Configuration menu - View commit details
-
Copy full SHA for b0f4ace - Browse repository at this point
Copy the full SHA b0f4aceView commit details -
refactor: convert
shapes/util.js
to TypeScriptConvert the `packages/mermaid/src/rendering-util/rendering-elements/shapes/util.js` file to TypeScript at: `packages/mermaid/src/rendering-util/rendering-elements/shapes/util.ts`.
Configuration menu - View commit details
-
Copy full SHA for 62fd359 - Browse repository at this point
Copy the full SHA 62fd359View commit details -
refactor: remove some
any
types from render()This let's us confirm that the types we're passing to `insertNode()` are valid.
Configuration menu - View commit details
-
Copy full SHA for 16a5fc0 - Browse repository at this point
Copy the full SHA 16a5fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 606ecf8 - Browse repository at this point
Copy the full SHA 606ecf8View commit details
Commits on Oct 21, 2024
-
refactor: use more standard types
See: mermaid-js#5974 (comment) See: mermaid-js#5974 (comment) Co-authored-by: saurabhg772244 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4bc70b7 - Browse repository at this point
Copy the full SHA 4bc70b7View commit details -
refactor(elk): add
LabelData
type for layout-elkI don't know what exactly the type does or is for, but I've tried to type it to what it seems to be.
Configuration menu - View commit details
-
Copy full SHA for 6cc0132 - Browse repository at this point
Copy the full SHA 6cc0132View commit details
Commits on Oct 22, 2024
-
Handle `NaN` values by using `parseFontSize()`. Suggested-by: mermaid-js#5974 (comment)
Configuration menu - View commit details
-
Copy full SHA for bb97fdb - Browse repository at this point
Copy the full SHA bb97fdbView commit details -
refactor: move
MaybePromise
type to src/types.tsSuggested-by: mermaid-js#5974 (comment) Co-authored-by: Sidharth Vinod <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f8746be - Browse repository at this point
Copy the full SHA f8746beView commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b5cd101 - Browse repository at this point
Copy the full SHA b5cd101View commit details