Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Product Hunt promos & Update Promo bar #5987

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

huynhicode
Copy link
Member

@huynhicode huynhicode commented Oct 22, 2024

📑 Summary

This PR contains the following updates:

  • removes Product Hunt promos
  • updates taglines
  • other content updates

Resolves #n/a

📏 Design Decisions

Design decisions made by the Mermaid Chart team.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 6df1fa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 6df1fa1
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/671745ff0dca670008d4cdf6
😎 Deploy Preview https://deploy-preview-5987--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 4.67%. Comparing base (be57484) to head (6df1fa1).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../mermaid/src/docs/.vitepress/components/TopBar.vue 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5987   +/-   ##
======================================
  Coverage    4.67%   4.67%           
======================================
  Files         372     372           
  Lines       51669   51667    -2     
  Branches      611     586   -25     
======================================
  Hits         2414    2414           
+ Misses      49255   49253    -2     
Flag Coverage Δ
unit 4.67% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/mermaid/src/docs/.vitepress/theme/index.ts 0.00% <ø> (ø)
.../mermaid/src/docs/.vitepress/components/TopBar.vue 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 485 changed, 1 removed, 1 failure Oct 22, 2024, 6:49 AM

@sidharthv96 sidharthv96 merged commit e3ec6ed into master Oct 22, 2024
19 of 21 checks passed
@sidharthv96 sidharthv96 deleted the update-promos branch October 22, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants