-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a configuration example in gantt.md
#6001
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6001 +/- ##
=======================================
Coverage 4.48% 4.48%
=======================================
Files 383 382 -1
Lines 54048 54037 -11
Branches 596 621 +25
=======================================
Hits 2425 2425
+ Misses 51623 51612 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
According to the [config schema docs](https://mermaid.js.org/config/schema-docs/config-defs-gantt-diagram-config.html#tickinterval-constraints), Gantt's `tickInterval` configuration must match the following regular expression, which does **not** allow any space: ```regexp /^([1-9][0-9]*)(millisecond|second|minute|hour|day|week|month)$/ ```
c5831b1
to
8cb1c68
Compare
@michaelbaudino, Thank you for the contribution! |
📑 Summary
According to the config schema docs, Gantt's
tickInterval
configuration must match the following regular expression, which does not allow any space:This PR simply changes the example to be valid regarding this regular expression (otherwise, using the value in the example has no effect 😕).
📏 Design Decisions
N/A
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.