Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update changeset for #5880 #6009

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

aloisklink
Copy link
Member

📑 Summary

This isn't documented, but apparently changesets supports this in changesets/changesets@91d1ef2

This is needed to give @yari-dewalt credit for PR #5880 in #6008

Fixes 97c61d8

📏 Design Decisions

I'm not 100% if this will work, but let's see!

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

This isn't documented, but apparently changesets supports this in changesets/changesets@91d1ef2

This is needed to give @yari-dewalt credit for PR #5880
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 8a0ecc1
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67224c89e4632900088713c4
😎 Deploy Preview https://deploy-preview-6009--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.49%. Comparing base (b022943) to head (8a0ecc1).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6009   +/-   ##
======================================
  Coverage    4.49%   4.49%           
======================================
  Files         383     383           
  Lines       53925   53925           
  Branches      596     596           
======================================
  Hits         2425    2425           
  Misses      51500   51500           
Flag Coverage Δ
unit 4.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@knsv knsv merged commit ef9cbb6 into master Oct 30, 2024
16 of 21 checks passed
@knsv knsv deleted the chore/fix-changeset-for-#5880 branch October 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants