-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Node with text renders by default as Markdown #6087
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c7880d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6087 +/- ##
==========================================
- Coverage 4.49% 4.48% -0.02%
==========================================
Files 382 383 +1
Lines 53914 54067 +153
Branches 621 596 -25
==========================================
Hits 2425 2425
- Misses 51489 51642 +153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -917,4 +917,24 @@ graph TD | |||
} | |||
); | |||
}); | |||
it('68: should be able to string and markdown labels (#5824)', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('68: should be able to string and markdown labels (#5824)', () => { | |
it('68: should be able to render string and markdown labels (#5824)', () => { |
… text
📑 Summary
Adding differentiation between regular strings and markdown strings.
Resolves #5824 and #6048
📏 Design Decisions
Adding back createLabel for the cases where you do not want markdown text
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.