Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull request includes changes to improve t#6088 ndling of diamond shape intersections in flowcharts using the
@mermaid-js/layout-elk
package. The main updates involve fixing offset calculations and adding new test cases to ensure proper functionality.Improvements to diamond shape handling:
.changeset/hungry-guests-drive.md
: Updated offset calculations for diamond shapes to handle intersections more accurately.packages/mermaid-layout-elk/src/render.ts
: Adjusted the offset calculations and debug logs for diamond shapes in therender
function to improve intersection handling. [1] [2] [3] [4]Testing enhancements:
cypress/integration/rendering/flowchart-elk.spec.js
: Added multiple test cases to verify the correct handling of diamond shape intersections in various flowchart configurations.HTML updates:
cypress/platform/knsv2.html
: Updated themermaid
class in several<pre>
elements to ensure consistent rendering of flowcharts. [1] [2] [3] [4]Resolves #6088
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.