Skip to content

Conversation

weilirs
Copy link

@weilirs weilirs commented Jan 9, 2025

Description
#173 (comment)

This PR fixes this issue

Notes for Reviewers
Followed the instructions from Pranav, exported a design file with a cilium component from Kanvas and replaced the content of it with the existing deploy.yaml
https://layer5io.slack.com/archives/C017NA80S66/p1736126652434049?thread_ts=1736126645.139429&cid=C017NA80S66

Signed commits

  • Yes, I signed my commits.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weilirs how was this design created?

Change the title from "Untitled Design".

When I import this design into a Meshery Server, its validation fails with a missing property.

@leecalcote
Copy link
Member

As you work through this, please confirm that the design is deployable.

@weilirs
Copy link
Author

weilirs commented Jan 13, 2025

@weilirs how was this design created?

Change the title from "Untitled Design".

When I import this design into a Meshery Server, its validation fails with a missing property.

I ran meshery-cilium locally and ran the Meshery server, navigated to the Kanvas and dragged and dropped the "Cilium Clusterwide Envoy Config" and exported it as "Design File" and I replaced the content of deploy.yaml with the content of the exported Design File. I now exported a new one and named it as "pattern file" and I tried importing it and succeeded.
image

@weilirs weilirs requested a review from leecalcote January 16, 2025 16:02
@leecalcote
Copy link
Member

@weilirs, good progress. Two other aspects in need of confirmation:

  1. That the component used in the new design comes from the adapter.
  2. That the design created deploys.
  3. That the design deployment creates a Cilium service mesh.

@sangramrath sangramrath reopened this Mar 26, 2025
@sangramrath
Copy link

@weilirs any updates on the changes requested?

@weilirs
Copy link
Author

weilirs commented Mar 26, 2025

@weilirs any updates on the changes requested?

I encountered a problem confirming the details Lee mentioned. I asked in slack and the forum but have not heard back.
https://discuss.layer5.io/t/error-when-deploying-a-design/6703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TestAdapters workflow is failing
3 participants