Skip to content

Conversation

Babbili
Copy link

@Babbili Babbili commented Sep 26, 2025

Description

This PR fixes #646

Create Kubernetes Health Probles (Liveness probes on /healthz/live and Readiness probes on /healthz/ready for meshSync containers and keep their lifecycle and state observed for reliability and stability.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Sep 26, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

n2h9
n2h9 previously approved these changes Sep 27, 2025
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.63%. Comparing base (bbdd03c) to head (5f0f25f).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   36.01%   35.63%   -0.39%     
==========================================
  Files          17       17              
  Lines         783      783              
==========================================
- Hits          282      279       -3     
- Misses        481      483       +2     
- Partials       20       21       +1     
Flag Coverage Δ
unittests 35.63% <ø> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@n2h9 n2h9 self-requested a review September 27, 2025 11:06
@n2h9
Copy link
Contributor

n2h9 commented Sep 27, 2025

Hey hey @Babbili hello 👋!

Looks like integration test is failing as meshsync never reaches Ready state.

✅ meshsync deployment found
Now waiting for meshsync deployment to be ready...
error: timed out waiting for the condition on deployments/meshery-meshsync
❌ meshsync deployment failed to become ready
NAME                                READY   STATUS    RESTARTS      AGE
meshery-meshsync-565cc54bcc-4bq9x   0/1     Running   3 (35s ago)   5m5s

source

I think there are no actual endpoints in meshsync for /healthz/live and /healthz/ready on port 11000 that is the issue.

@n2h9 n2h9 dismissed their stale review September 28, 2025 06:55

meshsync doesn reach ready state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] Create Kubernetes Health Probles (Liveness and Readiness Probes) for meshSync containers.
2 participants