Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade staticcheck-action to v1.3.0 #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deeptanshu-sankhwar
Copy link

@Deeptanshu-sankhwar Deeptanshu-sankhwar commented Dec 29, 2024

This PR fixes meshery/meshery#13041, upgrading dominikh/[email protected] to dominikh/[email protected]

Signed commits

  • Yes, I signed my commits.

@lekaf974
Copy link

lekaf974 commented Jan 4, 2025

@Deeptanshu-sankhwar you need to signoff your commit to fix DCO

@Deeptanshu-sankhwar
Copy link
Author

Gotcha! Thanks @lekaf974 lemme recreate the PR with proper sign off.

@lekaf974
Copy link

lekaf974 commented Jan 5, 2025

Gotcha! Thanks @lekaf974 lemme recreate the PR with proper sign off.

Don't need to recreate a PR git commit --amend -s should be enough

Signed-off-by: Deeptanshu Sankhwar <[email protected]>
@Deeptanshu-sankhwar Deeptanshu-sankhwar force-pushed the fix/update-staticcheck-action branch from 006d492 to 8cf5cdd Compare January 6, 2025 04:51
@Deeptanshu-sankhwar
Copy link
Author

Done @lekaf974, thanks a bunch! Will do the same for other PRs failing DCO as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade statichcheck-action to v1.3.0 across all repos
2 participants