UI Fix: Modal Category Type Now Visible in Light/Dark Modes#2015
UI Fix: Modal Category Type Now Visible in Light/Dark Modes#2015vishalvivekm merged 11 commits intomeshery:masterfrom Tharanishwaran:fix/modal-category-light-dark-mode-visibility
Conversation
Signed-off-by: Tharanishwaran <tharanishwaran.ta@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Tharanishwaran <133676934+Tharanishwaran@users.noreply.github.com>
|
Hi @vishalvivekm @sudhanshutech could you please review this PR and let me know if any changes are needed. |
|
looks good |
Touriist
left a comment
There was a problem hiding this comment.
@Tharanishwaran
There should be no effect on hover; it just needs to stay as a chip.
Also, I understand that the following may not be within the scope of the corresponding issue, but could you please take a look at fixing these two points:
|
Thank you for the feedback @Touriist. I will address the hover effect and modal fixes promptly. |
Signed-off-by: Tharanishwaran <tharanishwaran.ta@gmail.com>
|
@Touriist However, regarding the first issue about modal height . I'm unable to reproduce or see any height-related problems in the current version. Could you please provide more details. |
|
@Tharanishwaran adding it as an agenda item to the meeting minutes. |
Signed-off-by: Tharanishwaran <tharanishwaran.ta@gmail.com>
…b.com:Tharanishwaran/meshery.io into fix/modal-category-light-dark-mode-visibility
|
@vishalvivekm Before Fix:Screencast.2025-01-15.05.18.49.mp4After Fix:Screencast.2025-01-15.05.18.00.mp4 |
|
@Tharanishwaran please be present in next website call and show your update so that it can be last reviewed and merged. |
|
@sudhanshutech Sorry for missing yesterday's website meeting, I'll be present in the next call for the final review. |
|
Thanks for your contribution to the Layer5 and Meshery community! 🎉
|





Description
This PR fixes #2010 #2017
Notes for Reviewers
Screenshot
Signed commits