Fix: Slack button visibility and alignment (#2304) #2311
Conversation
Signed-off-by: anukraticodes <[email protected]>
❌ Deploy Preview for mesheryio-preview failed.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @anukraticodes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses and resolves visibility and alignment issues concerning the Slack button on the meshery.io website. The primary goal was to streamline the button's implementation by removing duplicate elements and applying unified, responsive styling, ensuring a consistent user experience across different devices. Additionally, a minor syntax error in a related HTML include file was fixed, and project dependency tracking was initiated.
Highlights
- UI Fixes & Refinement: Eliminated redundant Slack buttons and consolidated their styling to ensure a single, consistently presented "Join Slack" link on the
lfx_2025.htmlpage. - Responsive Design: Applied existing responsive styling classes to the Slack button for consistent visibility and alignment across various screen sizes.
- Code Quality: Corrected a syntax error (missing closing brace) within a CSS media query block in the
_includes/subscribe.htmlfile. - Dependency Management: Added a
package-lock.jsonfile, indicating that Node.js project dependencies are now being tracked for consistent builds.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request addresses Slack button visibility and alignment issues by removing duplicate elements and standardizing the <a> tag. The review suggests refactoring an inline style into a CSS class for maintainability and questions the addition of an empty package-lock.json file. Additionally, it points out minor style inconsistencies in _includes/subscribe.html.
| { | ||
| "name": "meshery.io", | ||
| "lockfileVersion": 3, | ||
| "requires": true, | ||
| "packages": {} | ||
| } |
There was a problem hiding this comment.
This package-lock.json file is newly added but is empty. Lockfiles are crucial for ensuring reproducible builds, but an empty lockfile serves no purpose.
If this project uses npm, this file should be generated by npm install and reflect the dependencies in package.json. Committing an empty one can cause confusion or issues with CI/CD pipelines.
| <div> | ||
| <a href="https://slack.meshery.io" class="participate-button disappear">Join Slack</a> | ||
| </div> | ||
| <div class="text subscribe program__subscribe" style="margin: 1rem !important; padding: 1rem;"> |
There was a problem hiding this comment.
Using inline styles with !important can make the CSS difficult to maintain. It's better to encapsulate these styles within a CSS class.
Consider creating a new modifier class (e.g., program__subscribe--custom-spacing) and defining the margin and padding in your project's stylesheet. This promotes reusability and keeps your HTML cleaner.
<div class="text subscribe program__subscribe program__subscribe--custom-spacing">
|
Duplicates #2309 |
|
@anukraticodes |
|
@anukraticodes Do you have an update on this pr as @erinhdsilva has abandoned her pr solving the same issue. |
|
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
Description
This PR fixes the issue with the Slack button's visibility and alignment on the meshery.io website. The previous implementation had duplicate elements with inconsistent styling. This PR removes the redundant button and properly styles the remaining one for consistent appearance and behavior across devices.
Fixes #2304
Notes for Reviewers
<input type="button">wrapped in<a>)<a>elementSigned commits