-
Notifications
You must be signed in to change notification settings - Fork 712
Added Exoscale-icons both white and baground color #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: yash37158 <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @yash37158, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a rendering issue in the Meshery Editor where Exoscale icons were incorrectly displayed in white. I've resolved this by updating the fill values within the color folder assets to their accurate brand colors. This ensures that the icons now render as intended, maintaining proper color separation between white and colored versions. Additionally, I've introduced new icon sets for both red-themed and background-colored variations of the Exoscale icons.
Highlights
- Icon Color Correction: Exoscale icons now render in their correct brand colors within the Meshery Editor, resolving the previous issue of them appearing in white.
- Fill Value Update: The fill values for the color folder assets have been updated to accurately reflect the intended brand colors.
- Folder Separation Enforcement: The pull request ensures proper folder-level color separation, meaning white icons remain white, and color icons display their correct fills.
- New Icon Addition: New icons have been added for both Red Icons and Background Brand Color, expanding the available icon set.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new set of Exoscale icons with background colors and updates the existing icons to use their proper brand colors, addressing a rendering issue. While the effort to enhance the icon library is appreciated, there are several critical issues that need to be addressed. A new model definition for background icons references numerous non-existent SVG files, which will cause them to be broken. Additionally, a couple of the new SVG files contain incorrect CSS class names, which will lead to rendering errors. There are also some minor inconsistencies and opportunities for optimization across the new assets.
assets/images/custom-integration/exoscale-icons/components/price-icon-red.svg
Outdated
Show resolved
Hide resolved
assets/images/custom-integration/exoscale-icons/components/valkey-icon-red.svg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at Gemini's concerns
Signed-off-by: yash37158 <[email protected]>
![]() The shapes are still in white and background tar file is not working , can you check once @yash37158 |
That’s because there’s a rendering issue with the current Exoscale model. For other icon models, we see a request for -complete, but that request isn’t happening for the uploaded Exoscale model. I’ll push the fix soon... |
colorIcon: assets/images/custom-integration/exoscale-icons-background/components/cli-icon.svg | ||
whiteIcon: assets/images/custom-integration/exoscale-icons-background/components/cli-icon.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yash37158, here, should both colorIcon and whiteIcon be separate paths?
Both have the same file paths now, but maybe one of them should have the paths to the newly added SVGs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for calling this out @M-DEV-1. In the background-optimised Exoscale set, each icon is a single-color, background-safe asset intended to render the same in both “color” and “white” contexts. We didn’t produce a separate white-tinted drawing for this set, so to keep the model schema uniform and downstream, both colorIcon and whiteIcon intentionally point to the same file.
@Namanv0509 @M-DEV-1 I have updated the tar file for the background icons. You can check with this one. |
Description
This PR addresses an issue where Exoscale icons rendered in white instead of their intended brand colors when imported into the Meshery Editor via the catalog.
Both the color and white folders inside the original .tar file used identical fill values, which resulted in all icons rendering white by default—regardless of folder intent.
✅ What’s fixed:-
Updated the color folder assets with accurate brand color fill values.
Ensured folder-level color separation is respected (i.e., white stays white, color shows correct fills).
Exported and verified the new icon model locally with correct rendering behavior in canvas.
Added for both Red Icons and Background Brand Color.
Screenshot:

This PR fixes #
Notes for Reviewers
Signed commits