Sam3 instance bonding#59
Open
demoulinv wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "masks bonding" feature to the SAM3 image and video segmentation nodes in Meshroom, allowing overlapping instance masks to be merged using morphological operations. The change is configurable via new parameters and is implemented consistently across all relevant segmentation nodes and processing pipelines.
Feature: Masks Bonding for Overlapping Instances
enableBonding(bool) andbondingKernelSize(int) to the following nodes:ImageSegmentationSam3,VideoSegmentationSam3,VideoSegmentationSam3Text, andVideoSegmentationSam3Boxes, enabling users to control bonding behavior and kernel size for morphological processing.Implementation: Mask Bonding Logic
bond_masksinsam3Utils.pythat performs dilation, conflict region detection, and morphological closing to merge overlapping masks, controlled by kernel size parameters.Integration: Processing Pipeline Updates
processChunkmethods to use the new bonding feature: when enabled and multiple masks are present, masks are merged using the bonding kernel size. This affects both forward and backward propagation in video segmentation, as well as tiling and text-prompted segmentation.Documentation and Versioning
VideoSegmentationSam3Boxesto 4.1.These changes collectively provide more robust control over how overlapping segmentation masks are handled, improving the quality of mask outputs in scenarios with touching or overlapping objects.