feat: add rate limit exceeded error message #2461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new error message for when the routing rate limit is exceeded. The following changes were made: - Added a new string resource for the rate limit exceeded error message. - Updated the `Message.kt` file to include the new error message in the routing error handling. Signed-off-by: James Rich <[email protected]>
jamesarich
force-pushed
the
feat/rate-limit-error
branch
from
1e9839e to
6e284bb
Compare
Signed-off-by: James Rich <[email protected]>
thebentern
approved these changes
Jul 21, 2025
|
fwict @thebentern this should kick the message status to you should be able to test w/ the debug apk against a fw (with the new routing error built in) off the action run once it's done |
There was a problem hiding this comment.
Pull Request Overview
This PR adds handling for a new rate limit exceeded error in the routing system by introducing an appropriate error message and mapping it to the corresponding routing error code.
- Adds a new string resource for rate limit exceeded error messages
- Updates the routing error mapping function to handle the new RATE_LIMIT_EXCEEDED error type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds new string resource for rate limit exceeded error message |
| app/src/main/java/com/geeksville/mesh/model/Message.kt | Maps the new RATE_LIMIT_EXCEEDED error value to the corresponding string resource |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new error message for when the routing rate limit is exceeded.
The following changes were made:
Message.ktfile to include the new error message in the routing error handling.this is in response to meshtastic/protobufs#735 and closes #2436