Skip to content

Conversation

poliver
Copy link
Member

@poliver poliver commented Sep 29, 2025

  • Adds section titles ("filter" and "sort") to node filter dropdown
  • Adds radio buttons to sort options, since they are single-selection
  • Adds check boxes to filter options, since they are multi-selection
  • Don't close the menu after each selection. This is especially annoying when selecting filters.
Before After
Screen_recording_20250929_195714.mp4
Screen_recording_20250929_195145.mp4

@poliver poliver added enhancement New feature or request ui Something to do with the UI of the Android app labels Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.35%. Comparing base (6abe012) to head (74123d9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lle/mesh/ui/node/components/NodeFilterTextField.kt 0.00% 53 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3250   +/-   ##
=====================================
  Coverage   0.35%   0.35%           
=====================================
  Files        292     292           
  Lines      19188   19174   -14     
  Branches    2359    2362    +3     
=====================================
  Hits          68      68           
+ Misses     19105   19091   -14     
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DaneEvans DaneEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@poliver poliver added this pull request to the merge queue Sep 30, 2025
Merged via the queue into main with commit cf59033 Sep 30, 2025
8 of 9 checks passed
@poliver poliver deleted the node_list_filter_menu branch September 30, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui Something to do with the UI of the Android app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants