-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
NimbleBLE update to 2.3.6 #7880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
This will need to be tested thoroughly on ESP32 / ESP32S3 and C3 targets on both Android and iOS, as we've experienced regressions in almost every big NimBLE upgrade. |
I Tested with Android + ESP32-S3 and ESP32-C3, can build a ESP32 hardware if needed, |
@Links2004 I manually pulled part of this patch in, to get support for an upcoming esl32-c6 device ironed out. I would love to get this PR to apply the new nimble version to all the c6 devices. We can use them as a test platform to find any outstanding problems. |
will rebase to fix the conflicts |
52275b5
to
e7a98a2
Compare
@jp-bennett did find one missing ifdef |
b5bbb1d
to
f592272
Compare
looks like that the ESP32 is running out of RAM. the pax module for example has had a short look and there is a loot of big static buffers and allocations in the firmware:
|
opend some PRs to save some memory with some easy changes, lets see if the builds work again after. |
Some of these embedded platforms have essentially zero memory management, and memory fragmentation is effectively the same thing as memory leaking. So we have intentionally gone with static memory over dynamic allocation in a lot of places. #8055 in particular looks really good, to save ram. |
did start work on the I2C sensor devices: #8054 |
f592272
to
bc9a3d5
Compare
This PR update NimbleBLE to 2.3.6 and does the needed migrations.
🤝 Attestations
ESP32-S3 + RF95
ESP32-C3 + RF95